[cfe-commits] Fix search path for clang on latest DragonFly releases [revised patches]

[Jordan Rose]

On Dec 20, 2012, at 10:22 , John Marino <draco at marino.st> wrote:

> On 12/20/2012 19:18, Rafael Espíndola wrote:
>>> Is that not a good enough test?
>> 
>> No. It has to be in check-all.
> 
> There's no problem in passing that.
> I will update the patch to fix USE_GCC47 and provide the results of check-all in my next post.
> 
> I was hoping for an answer to who from clang would test this and how they would, or would the burden of the test just come back to me anyway.  I asked because it's not getting tested now, so I am thinking clang team does not have the capacity to do it.

I think what Rafael is trying to explain is that any driver patches need to have platform-independent tests that everyone will run as part of check-clang. Of course this doesn't prove that DragonFly is actually working, or that it's not broken in some other way, but it does ensure that no one breaks the changes you are making right now.

I see you have one changed test file, but it's not testing each of the different changes you're making. It would be nice, for example, to actually show that clang correctly picks between gcc47 and gcc44 depending on what's in the filesystem; take a look at the other sysroot-based tests for that.

As you pointed out, we have a DragonFly test in our test suite...and it was totally useless because it didn't test the right things, and thus we on trunk didn't know that DragonFly was completely broken. Obviously we can't test things end-to-end without a DragonFly bot, but all this configuration stuff can at least be in the test suite so we know what's expected/necessary.

Jordan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121220/cbda61cd/attachment.html>