[cfe-commits] r170563 - /cfe/trunk/lib/AST/CommentParser.cpp

[Douglas Gregor]

On Dec 19, 2012, at 9:17 AM, Dmitri Gribenko <gribozavr at gmail.com> wrote:

> Author: gribozavr
> Date: Wed Dec 19 11:17:09 2012
> New Revision: 170563
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=170563&view=rev
> Log:
> Comment parsing: add a missing 'else'.  Found by inspection.
> 
> No testcase because we were just building an extra AST node and eventually
> throwing it away, so it did not affect correctness.

So, can we teach Clang to warn about this form of mistake?

	- Doug

> Modified:
>    cfe/trunk/lib/AST/CommentParser.cpp
> 
> Modified: cfe/trunk/lib/AST/CommentParser.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/CommentParser.cpp?rev=170563&r1=170562&r2=170563&view=diff
> ==============================================================================
> --- cfe/trunk/lib/AST/CommentParser.cpp (original)
> +++ cfe/trunk/lib/AST/CommentParser.cpp Wed Dec 19 11:17:09 2012
> @@ -318,7 +318,7 @@
>     PC = S.actOnParamCommandStart(Tok.getLocation(),
>                                   Tok.getEndLocation(),
>                                   Tok.getCommandID());
> -  } if (Info->IsTParamCommand) {
> +  } else if (Info->IsTParamCommand) {
>     IsTParam = true;
>     TPC = S.actOnTParamCommandStart(Tok.getLocation(),
>                                     Tok.getEndLocation(),
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits