[cfe-commits] [PATCH] OpenCL event type

[Dmitri Gribenko]

On Thu, Dec 20, 2012 at 1:13 PM, Benyei, Guy <guy.benyei at intel.com> wrote:
> Hi Dmitri,
> Thanks for the review.
>
> Attached the updated patch. Please review.

Diagnostics look good now, thanks!

+static bool TryOCLNULLEventInitialization(Sema &S,
+                                          InitializationSequence &Sequence,
+                                          QualType DestType,
+                                          Expr *Initializer) {
+  if (!S.getLangOpts().OpenCL || !DestType->isEventT() ||
+    !Initializer->getType()->isIntegralType(S.getASTContext()))

Please align the second line of condition to the first ('!' should line up).

Unfortunately, I don't think I can review the rest.

Dmitri

-- 
main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
(j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/