[cfe-commits] [PATCH] [Wdocumentation] Please update the description -- clang/AST/VTTBuilder.h

[Rafael Espíndola]

LGTM

On 13 November 2012 19:39, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
> /// \param AddressPoints - If the vtable is a construction vtable, this has the address points for it.
>
> AddressPoints (in 3 methods) has been removed in r140498, by Peter Collingbourne.
>
> Feel free to update them.
>
>
> http://llvm-reviews.chandlerc.com/D117
>
> Files:
>   clang/include/clang/AST/VTTBuilder.h
>
> Index: clang/include/clang/AST/VTTBuilder.h
> ===================================================================
> --- clang/include/clang/AST/VTTBuilder.h
> +++ clang/include/clang/AST/VTTBuilder.h
> @@ -102,9 +102,6 @@
>    bool GenerateDefinition;
>
>    /// AddVTablePointer - Add a vtable pointer to the VTT currently being built.
> -  ///
> -  /// \param AddressPoints - If the vtable is a construction vtable, this has
> -  /// the address points for it.
>    void AddVTablePointer(BaseSubobject Base, uint64_t VTableIndex,
>                          const CXXRecordDecl *VTableClass);
>
> @@ -117,20 +114,14 @@
>    ///
>    /// \param BaseIsMorallyVirtual whether the base subobject is a virtual base
>    /// or a direct or indirect base of a virtual base.
> -  ///
> -  /// \param AddressPoints - If the vtable is a construction vtable, this has
> -  /// the address points for it.
>    void LayoutSecondaryVirtualPointers(BaseSubobject Base,
>                                        bool BaseIsMorallyVirtual,
>                                        uint64_t VTableIndex,
>                                        const CXXRecordDecl *VTableClass,
>                                        VisitedVirtualBasesSetTy &VBases);
>
>    /// LayoutSecondaryVirtualPointers - Lay out the secondary virtual pointers
>    /// for the given base subobject.
> -  ///
> -  /// \param AddressPoints - If the vtable is a construction vtable, this has
> -  /// the address points for it.
>    void LayoutSecondaryVirtualPointers(BaseSubobject Base,
>                                        uint64_t VTableIndex);
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>