[cfe-commits] clang formatter patch to move and rename RewriterTestContext.h

jahanian fjahanian at apple.com
Mon Dec 17 10:06:47 PST 2012


On Dec 17, 2012, at 9:55 AM, Daniel Jasper <djasper at google.com> wrote:

> Hi Fariborz,
> 
> I am taking a look at your patch, but please bear with me for another day or two. I am not yet convinced that mingling C++ and ObjC formatting that closely is a wise decision. I think we might need something that clearly separates the different modes. And you touch a lot of code that I intended to refactor into something halfway sane this week. I will take your patch into consideration when doing so, but it might need some changes afterwards.
> 
> As for RewriterTestContext, please try to figure out whether that is really something you want to reuse in libclang. If so, I am happy to move it into include/clang/Tooling (or you could do that yourself). But I suspect that we want something different there, possibly a completely different interface.
> 

Can we move it, as is, to include/clang/Tooling? We can certainly think of a public interface later on? If you agree, I can do that.

- Thanks, Fariborz


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121217/ef97f7e5/attachment.html>


More information about the cfe-commits mailing list