[cfe-commits] [PATCH] First OpenMP patch

[Hal Finkel]

----- Original Message -----
> From: "Dmitri Gribenko" <gribozavr at gmail.com>
> To: "Hal Finkel" <hfinkel at anl.gov>
> Cc: "Chandler Carruth" <chandlerc at google.com>, "Douglas Gregor" <dgregor at apple.com>, "benny kra"
> <benny.kra at gmail.com>, "Alexey Bataev" <a.bataev at gmx.com>, "llvm cfe" <cfe-commits at cs.uiuc.edu>
> Sent: Monday, December 17, 2012 11:14:07 AM
> Subject: Re: [cfe-commits] [PATCH] First OpenMP patch
> 
> On Mon, Dec 17, 2012 at 6:26 PM, Hal Finkel <hfinkel at anl.gov> wrote:
> > ----- Original Message -----
> >> From: "Chandler Carruth" <chandlerc at google.com>
> >> To: "Hal Finkel" <hfinkel at anl.gov>
> >> Cc: "Dmitri Gribenko" <gribozavr at gmail.com>, "benny kra"
> >> <benny.kra at gmail.com>, "Alexey Bataev" <a.bataev at gmx.com>,
> >> "llvm cfe" <cfe-commits at cs.uiuc.edu>
> >> Sent: Monday, December 17, 2012 8:42:03 AM
> >> Subject: Re: [cfe-commits] [PATCH] First OpenMP patch
> >>
> >>
> >>
> >> On Mon, Dec 17, 2012 at 5:45 AM, Hal Finkel < hfinkel at anl.gov >
> >> wrote:
> >>
> >>
> >>
> >>
> >>
> >> ----- Original Message -----
> >> > From: "Dmitri Gribenko" < gribozavr at gmail.com >
> >> > To: "Alexey Bataev" < a.bataev at gmx.com >
> >> > Cc: "Hal Finkel" < hfinkel at anl.gov >, cfe-commits at cs.uiuc.edu ,
> >> > "mahesha llvm" < mahesha.llvm at gmail.com >, "benny kra"
> >> > < benny.kra at gmail.com >
> >> > Sent: Monday, December 17, 2012 6:45:07 AM
> >> > Subject: Re: [cfe-commits] [PATCH] First OpenMP patch
> >> >
> >>
> >> > On Mon, Dec 17, 2012 at 11:48 AM, Alexey Bataev <
> >> > a.bataev at gmx.com
> >> > >
> >> > wrote:
> >> > > Dmitry, Hal,
> >> > > Thank you for your comments and sorry for the delay, I was on
> >> > > a
> >> > > vacation.
> >> > > I've made some fixes according to your comments.
> >> > > Hal, I've change the sentence in the doc. Now there is only
> >> > > one
> >> > > warning, if
> >> > > any OpenMP pragma is found.
> >> > > Dmitry, I've changed the processing of the -fno-openmp flag.
> >> > > If
> >> > > -fno-openmp
> >> > > is specified, the option -Wno-source-uses-openmp is passed to
> >> > > the
> >> > > frontend.
> >> > > Option -Wsource-uses-openmp is on by default.
> >> >
> >> > Hello Alexey,
> >> >
> >> > This patch looks good to me.
> >>
> >> This also looks good to me. In nobody objects in the next day or
> >> so,
> >> please commit.
> >>
> >>
> >> Sorry that this got lost Hal, but I have said on another thread
> >> about
> >> this patch (but with a different author) that I don't really think
> >> we should add documentation and the beginnings of support for
> >> -fopen-mp without first having a clear discussion and document
> >> describing the expected design of OpenMP support in Clang.
> >
> > Regarding the documentation, I agree. It would be better to leave
> > it out at this point (we probably don't want docs for such an
> > incomplete feature to appear on the web site at present), although
> > it should still be developed.
> 
> If this is a concern (it is in my opinion), just put a ".. warning::"
> on top of the page saying that OpenMP support is under development.
> 
> Keeping documentation in the repository is much better since anyone
> touching OpenMP can be directed to the in-repository document (to
> read
> or update it), instead of pointing somewhere to the outside.

Agreed. Even so, we may want not to link to it from elsewhere.

> 
> What is more important than documentation, is the change in behavior.
> Someone might have used '-fopenmp' with Clang before, and now they
> will get an incomplete implementation.  We might also introduce a
> warning to Clang like "experimental OpenMP support enabled" for the
> time being.

Good idea.

 -Hal

> 
> Dmitri
> 
> --
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
> 

-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory