[cfe-commits] [PATCH] First OpenMP patch

Hal Finkel hfinkel at anl.gov
Mon Dec 17 05:45:45 PST 2012


----- Original Message -----
> From: "Dmitri Gribenko" <gribozavr at gmail.com>
> To: "Alexey Bataev" <a.bataev at gmx.com>
> Cc: "Hal Finkel" <hfinkel at anl.gov>, cfe-commits at cs.uiuc.edu, "mahesha llvm" <mahesha.llvm at gmail.com>, "benny kra"
> <benny.kra at gmail.com>
> Sent: Monday, December 17, 2012 6:45:07 AM
> Subject: Re: [cfe-commits] [PATCH] First OpenMP patch
> 
> On Mon, Dec 17, 2012 at 11:48 AM, Alexey Bataev <a.bataev at gmx.com>
> wrote:
> > Dmitry, Hal,
> > Thank you for your comments and sorry for the delay, I was on a
> > vacation.
> > I've made some fixes according to your comments.
> > Hal, I've change the sentence in the doc. Now there is only one
> > warning, if
> > any OpenMP pragma is found.
> > Dmitry, I've changed the processing of the -fno-openmp flag. If
> > -fno-openmp
> > is specified, the option -Wno-source-uses-openmp is passed to the
> > frontend.
> > Option -Wsource-uses-openmp is on by default.
> 
> Hello Alexey,
> 
> This patch looks good to me.

This also looks good to me. In nobody objects in the next day or so, please commit. The documentation will need to be converted to rst (sphinx) format as most of the others now are. It should be simply enough to convert the two paragraphs you have so far, so please do that either before you commit or in a follow-up soon after.

Thanks again,
Hal

> 
> Dmitri
> 
> --
> main(i,j){for(i=2;;i++){for(j=2;j<i;j++){if(!(i%j)){j=0;break;}}if
> (j){printf("%d\n",i);}}} /*Dmitri Gribenko <gribozavr at gmail.com>*/
> 

-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory



More information about the cfe-commits mailing list