[cfe-commits] r167539 - in /cfe/trunk: include/clang/Serialization/ModuleManager.h lib/Frontend/CompilerInstance.cpp lib/Serialization/ASTReader.cpp lib/Serialization/ModuleManager.cpp test/Modules/Inputs/Modified/ test/Modules/Inputs/Modified/A.h test/Modules/Inputs/Modified/B.h test/Modules/Inputs/Modified/module.map test/Modules/modify-module.m

[Douglas Gregor]

On Dec 11, 2012, at 2:16 PM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:

> 2012/12/12 Douglas Gregor <dgregor at apple.com>:
>>> Doug, excuse me to comment older commit.
>>> 
>>> Should be?
>>> // {expected-no-diagnostics}
>>> 
>>> Or I can see below;
>>> 
>>> error: no expected directives found: consider use of 'expected-no-diagnostics'
>>> 1 error generated.
>>> 
>>> (But clang exits successfully regardless of braces…)
>> 
>> This might be weirdness with the Windows file system, which we've seen before. We could replace the 'touch' command with an rm/cp pair, so we're certain that the B.h getting included is different.
> 
> I'd like to know why "1 error generated." didn't raise error status
> with -verify, (not only on windows).

I *think* the -verify gets dropped when Clang goes off and spawns another compiler instance to build a module.

	- Doug