[cfe-commits] Fix libstdc++ header search paths on Gentoo

Eli Friedman eli.friedman at gmail.com
Mon Dec 10 14:48:04 PST 2012


On Sat, Dec 1, 2012 at 10:06 AM, Timothy B. Terriberry
<tterriberry at mozilla.com> wrote:
> Chandler Carruth wrote:
>>
>> Several folks have wanted to remove the break after the first one is
>> found -- however, that is not a correct change. We cannot add multiple
>> libstdc++ versions' include trees to compiles, and removing the break
>> runs the risk of that.
>
>
> If that's the only concern, I'd be happy to modify the patch to stop once it
> finds a combination of directories that provides both of the candidate
> headers I'm looking for in this patch.

I think this is the primary concern.  Well, that and you didn't update
test/Driver/linux-header-search.cpp with a testcase.  It'd be nice to
get Gentoo to fix their libstdc++ install, but that doesn't mean we'll
refuse to patch clang.

-Eli



More information about the cfe-commits mailing list