[cfe-commits] [PATCH] Invariants (and Assume Aligned) - Clang

[Hal Finkel]

----- Original Message -----
> From: "Tobias Grosser" <tobias at grosser.es>
> To: reviews+D149+public+707ba5224a940551 at llvm-reviews.chandlerc.com
> Cc: hfinkel at anl.gov, cfe-commits at cs.uiuc.edu
> Sent: Wednesday, December 5, 2012 4:04:54 PM
> Subject: Re: [cfe-commits] [PATCH] Invariants (and Assume Aligned) - Clang
> 
> On 12/05/2012 09:39 PM, hfinkel at anl.gov wrote:
> >    Test cases have been enhanced. We now use @llvm.invariant.
> 
> > Index: test/CodeGen/builtin-assume.c
> > ===================================================================
> > --- /dev/null
> > +++ test/CodeGen/builtin-assume.c
> > @@ -0,0 +1,9 @@
> > +// RUN: %clang_cc1 -triple x86_64-unknown-unknown -emit-llvm -o -
> > %s | FileCheck %s
> > +
> > +// CHECK: @test1
> > +int test1(int *a) {
> > +// CHECK: call void @llvm.invariant(i1
> > +  __builtin_assume(a != 0);
> > +  return a[0];
> 
> The second check line looks incomplete? Is this intended?

Yes. I did not want to match the variable name specifying the condition.

[For some reason, I can't see this comment in the web interface].

 -Hal

> 
> Cheers
> Tobi
> 

-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory