[cfe-commits] [Patch] Add a function to libclang for retrieving the bit width value

[Argyrios Kyrtzidis]

On Dec 3, 2012, at 4:46 PM, Jyun-Yan You <jyyou.tw at gmail.com> wrote:

> On Wed, Nov 7, 2012 at 4:48 PM, Jyun-Yan You <jyyou.tw at gmail.com> wrote:
>> On Wed, Nov 7, 2012 at 2:26 PM, Douglas Gregor <dgregor at apple.com> wrote:
>>> 
>>> On Nov 6, 2012, at 4:41 PM, Jyun-Yan You <jyyou.tw at gmail.com> wrote:
>>> 
>>> The patch looks good, but can you please add a test? For example, update c-index-test to print out the bit width, and update one of the tests in test/Index.
>>> 
>>>        - Doug
>>> 
>> 
>> Here is a new patch which contains a test.
>> Thank you.
> 
> Ping. Could somebody help me?

Hi,

Only a couple of nitpicks:

1) Since this is an API addition, please increase the CINDEX_VERSION_MINOR number.
2) For testing you only display fields that have bitwidths. Please also include "CHECK-NOT:" lines for the non-bitfield fields to make sure we don't report them as bitfields by mistake.

-Argyrios

> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits