[cfe-commits] r168958 - in /cfe/trunk/lib: Basic/Targets.cpp Driver/Tools.cpp

[Quentin Colombet]

Hi Chandler,

Here is a patch with a test case.

I didn't put a test case in the original patch as Evan suggested me to remove it for the related commit on the llvm side.

Quentin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang-cortex-a5-testcase.patch
Type: application/octet-stream
Size: 307 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121129/6d143e1e/attachment.obj>
-------------- next part --------------


On Nov 29, 2012, at 4:19 PM, Chandler Carruth <chandlerc at google.com> wrote:

> Test case please?
> 
> On Thu, Nov 29, 2012 at 3:15 PM, Quentin Colombet <qcolombet at apple.com> wrote:
>> Author: qcolombet
>> Date: Thu Nov 29 17:15:27 2012
>> New Revision: 168958
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=168958&view=rev
>> Log:
>> Add ARM cortex-a5 subtarget
>> 
>> Modified:
>>    cfe/trunk/lib/Basic/Targets.cpp
>>    cfe/trunk/lib/Driver/Tools.cpp
>> 
>> Modified: cfe/trunk/lib/Basic/Targets.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=168958&r1=168957&r2=168958&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/Basic/Targets.cpp (original)
>> +++ cfe/trunk/lib/Basic/Targets.cpp Thu Nov 29 17:15:27 2012
>> @@ -3213,7 +3213,7 @@
>>       .Cases("arm1176jz-s", "arm1176jzf-s", "6ZK")
>>       .Cases("arm1136jf-s", "mpcorenovfp", "mpcore", "6K")
>>       .Cases("arm1156t2-s", "arm1156t2f-s", "6T2")
>> -      .Cases("cortex-a8", "cortex-a9", "cortex-a15", "7A")
>> +      .Cases("cortex-a5", "cortex-a8", "cortex-a9", "cortex-a15", "7A")
>>       .Case("cortex-a9-mp", "7F")
>>       .Case("swift", "7S")
>>       .Cases("cortex-m3", "cortex-m4", "7M")
>> 
>> Modified: cfe/trunk/lib/Driver/Tools.cpp
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=168958&r1=168957&r2=168958&view=diff
>> ==============================================================================
>> --- cfe/trunk/lib/Driver/Tools.cpp (original)
>> +++ cfe/trunk/lib/Driver/Tools.cpp Thu Nov 29 17:15:27 2012
>> @@ -471,7 +471,7 @@
>>     .Cases("arm1136j-s",  "arm1136jf-s",  "arm1176jz-s", "v6")
>>     .Cases("arm1176jzf-s",  "mpcorenovfp",  "mpcore", "v6")
>>     .Cases("arm1156t2-s",  "arm1156t2f-s", "v6t2")
>> -    .Cases("cortex-a8", "cortex-a9", "cortex-a15", "v7")
>> +    .Cases("cortex-a5", "cortex-a8", "cortex-a9", "cortex-a15", "v7")
>>     .Case("cortex-m3", "v7m")
>>     .Case("cortex-m4", "v7m")
>>     .Case("cortex-m0", "v6m")
>> @@ -610,7 +610,7 @@
>>     CmdArgs.push_back("+neonfp");
>> 
>>     if (CPU != "cortex-a8" && CPU != "cortex-a9" && CPU != "cortex-a9-mp" &&
>> -        CPU != "cortex-a15")
>> +        CPU != "cortex-a15" && CPU != "cortex-a5")
>>       D.Diag(diag::err_drv_invalid_feature) << "-mfpmath=neon" << CPU;
>> 
>>   } else if (FPMath == "vfp" || FPMath == "vfp2" || FPMath == "vfp3" ||
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits