[cfe-commits] [PATCH] Add three new sanitizers depending on ASan.

[Alexey Samsonov]

================
Comment at: lib/CodeGen/BackendUtil.cpp:145
@@ +144,3 @@
+  const LangOptions &getLangOpts() const { return LangOpts; }
+ private:
+  const LangOptions &LangOpts;
----------------
Dmitri Gribenko wrote:
> Extra space before 'private:' and 'public:'.
Done

================
Comment at: lib/CodeGen/BackendUtil.cpp:173-175
@@ +172,5 @@
+                                      PassManagerBase &PM) {
+  const PassManagerBuilderWrapper *BuilderWrapper =
+      static_cast<const PassManagerBuilderWrapper*>(&Builder);
+  assert(BuilderWrapper);
+  const LangOptions &LangOpts = BuilderWrapper->getLangOpts();
----------------
Richard Smith wrote:
> Maybe cast Builder to 'const PassManagerBuilderWrapper &'?
Done

================
Comment at: docs/UsersManual.html:903
@@ -900,3 +902,3 @@
 
-The following more fine-grained checks are also available:
+The following more fine-grained undefined behavior checks are available:
 
----------------
Richard Smith wrote:
> -fsanitize=unsigned-integer-overflow isn't an undefined behavior check. Maybe there's a better way of organizing this section.
Um, right. Reverted this line.


http://llvm-reviews.chandlerc.com/D142