[cfe-commits] [Review] First step towards PR13231 - vftable generation with -cxx-abi microsoft

[Timur Iskhodzhanov]

Thanks for the review!

On Thu, Nov 29, 2012 at 2:52 AM, John McCall <rjmccall at apple.com> wrote:
> +  // FIXME: Should probably add a layer of abstraction for vtable
> +  // generation, see http://llvm.org/bugs/show_bug.cgi?id=13231#c5
> +  bool MsABI = (Context.getTargetInfo().getCXXABI() == CXXABI_Microsoft);
>
> Please don't litter the code with PR references.
Quick question - what's better?
(1)
// FIXME: Should probably add a layer of abstraction for vtable
// generation, see PR13231#c5

(2)
// FIXME: Should probably add a layer of abstraction for vtable generation.
(that's 75 chars - close to the line limit)

(3)
// FIXME: <your text here>