[cfe-commits] r168303 - in /cfe/trunk/test: Analysis/malloc.c SemaObjCXX/pointer-to-objc-pointer-conv.mm

NAKAMURA Takumi geek4civic at gmail.com
Wed Nov 28 19:03:44 PST 2012


Thanks!

Jordan, I know your tweak should be *the right thing*, though I think
it would be too trivial to be pulled in release_32.

2012/11/29 Pawel Wodnicki <pawel at 32bitmicro.com>:
>> On Nov 28, 2012, at 3:47 AM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
>>> John, I propose you please to approve r168303 for release_32.
>>>
>>> It's a suppression to two tests for Windows x64 (and possibly
>>> mingw-w64 x64) to pass clang tests.
>>> See also; http://llvm.org/bugs/show_bug.cgi?id=8833
>>>
>>> Confirmed with x64|MinSizeRel on visual studio 10.
>>
>> Yes, this is fine.  I don't particularly see a need to take Jordan's patch updating the test instead, but if you'd rather do that, it's probably the right thing.
>>
>> John.
>>
>>
>
> Committed revision 168823.
>
> Pawel
>



More information about the cfe-commits mailing list