[cfe-commits] [PATCH] Refactor -fsanitize arguments parsing: provide a more careful diagnostic.
Alexey Samsonov
samsonov at google.com
Wed Nov 28 09:36:15 PST 2012
r168794
================
Comment at: lib/Driver/SanitizerArgs.h:137-140
@@ +136,6 @@
+ I != E; ++I) {
+ unsigned Add, Remove;
+ if (parse(D, Args, *I, Add, Remove, false) &&
+ (Add & Kind))
+ return describeSanitizeArg(Args, *I, Kind);
+ }
----------------
Richard Smith wrote:
> The contract for this function would be nicer if you could just pass in (say) NeedsUbsanRt, not Kind & NeedsUbsanRt.
>
> Adding "Kind &= ~Remove;" here should have that effect, I think.
Indeed, thanks!
http://llvm-reviews.chandlerc.com/D143
BRANCH
svn
ARCANIST PROJECT
clang
More information about the cfe-commits
mailing list