[cfe-commits] [PATCH] Fix for PR12222

Douglas Gregor dgregor at apple.com
Tue Nov 27 13:01:59 PST 2012


On Nov 24, 2012, at 7:29 AM, Erik Verbruggen <erik.verbruggen at me.com> wrote:

> Ping?
> 
> Attached is an update patch against rev. #168535.
> 
> <0001-PATCH-Fix-for-PR12222.patch>

Commit message says "getSourceLocation()" when it means "getSourceRange()":

Changed getLocStart() and getLocEnd() to be required for Stmts, and make
getSourceLocation() optional. The default implementation for
getSourceLocation() is build the range by calling getLocStart() and
getLocEnd().

This is expected to be a performance win. Is it?

	- Doug

> On Nov 5, 2012, at 12:53, Erik Verbruggen <erik.verbruggen at me.com> wrote:
> 
>> Changed getLocStart() and getLocEnd() to be required for Stmts, and make getSourceLocation() optional. The default implementation for getSourceLocation() is build the range by calling getLocStart() and getLocEnd().
>> 
>> Patch against rev. #167353. 
>> 
>> <0001-Fix-for-PR12222.patch>_______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 




More information about the cfe-commits mailing list