[cfe-commits] [PATCH v2] Set some OpenCl specification mandated types/alignments/etc

[David Tweed]

Revised patch actually attached.

-----Original Message-----
From: David Tweed [mailto:david.tweed at arm.com] 
Sent: 27 November 2012 16:09
To: 'Eli Friedman'
Cc: Pekka Jääskeläinen; cfe-commits at cs.uiuc.edu
Subject: RE: [PATCH v2] Set some OpenCl specification mandated
types/alignments/etc

Hi Eli, thanks for the feedback. In general I've tested everything I know
how to test using only the output of a compilation.

| Why are you messing with LargeArrayMinWidth and LargeArrayAlign?
| Please explain in the patch and add tests.

That looks like something I forgot was an implementation thing rather than
standard. Removed.

| Why are you messing with the floating point formats (particularly
| without setting the size and alignment alongside the format)?  Please
| explain in the patch and add tests.

I didn't really think about the floating point formats possibly changing
size; fixed. Explained in patch that all these things are language
specified.

| Is a fixed OpenCL address map really appropriate for every target?

This patch sets up the mandated address spaces for OpenCL; presumably
targets that want to add more can extend it themselves.

| Also, please wait at least a couple more days; all the Apple people
| were off last week, and I want to give them time to comment.

No problem waiting a while: the problem with patches areas (like this one)
in extremely dull areas is knowing if there's no response just because it's
so uninteresting rather than there hasn't been time for commenters, but I
forgot to factor in American Thanksgiving.

Regards,
Dave
-------------- next part --------------
A non-text attachment was scrubbed...
Name: opencl3.diff
Type: application/octet-stream
Size: 2473 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121127/7bb9509f/attachment.obj>