[cfe-commits] [PATCH v2] Set some OpenCl specification mandated types/alignments/etc

[Eli Friedman]

On Mon, Nov 26, 2012 at 9:05 AM, David Tweed <david.tweed at arm.com> wrote:
> Following the comments, it looks like there's not a strong objection to
> doing OpenCL mandated configuration this way and some support for this. So
> the attached patch is modified as suggested to use a specific target when
> testing the sizes/alignments. Unless there are further objections I'll
> commit in a day or so.

More comments from another look at the patch:

Why are you messing with LargeArrayMinWidth and LargeArrayAlign?
Please explain in the patch and add tests.

Why are you messing with the floating point formats (particularly
without setting the size and alignment alongside the format)?  Please
explain in the patch and add tests.

Is a fixed OpenCL address map really appropriate for every target?

Also, please wait at least a couple more days; all the Apple people
were off last week, and I want to give them time to comment.

-Eli