[cfe-commits] Fix search path for clang on latest DragonFly releases
Rafael EspĂndola
rafael.espindola at gmail.com
Mon Nov 26 08:21:52 PST 2012
>> It *needs* a test anyway. The code in the driver needs refactoring, so
>> it is double important that we test it. The test should go to
>> clang/test/Driver/.
>
>
>
> I'm not quite clear on this point. Are you saying that even if I had not
> proposed a patch, the driver would need refactoring? And because we are
> considering a patch, now is the time to do this? (I need to review the
> driver code which I don't have ATM to see what code segments need to be
> factored out, that's also not clear).
>
> What should be the objective of this test? to see if it can produce an
> executable?
I am saying that we will be changing the code in the future, and if
this change is not tested it is very likely that it will be broken.
The tests in test/Driver check the command lines used by the driver to
execute other tools, like the linker.
> John
Cheers,
Rafael
More information about the cfe-commits
mailing list