[cfe-commits] Fix search path for clang on latest DragonFly releases
John Marino
draco at marino.st
Mon Nov 26 05:46:55 PST 2012
On 11/26/2012 14:38, Rafael EspĂndola wrote:
>> However, what is the process to see this bug report 14417 accomplished? I
>> don't really want to stay subscribed to this mailing list for a single
>> patch. I would have thought opening a bug report alone would have been
>> sufficient.
>
> No, we do code reviews on the list. I guess you could use phabricator
> to get messages just on this thread, but I never used it myself so I
> am not sure.
>
> This patch needs a test. Note that with this patch the driver will be
> passing multiple -Ls to the linker. It would be better to detect which
> gcc instalation will be used and pass just that one. See
> GCCInstallationDetector for example.
Yes, it is passing multiple -L's to the linker. Is that in itself a
problem? Doesn't the linker check in the -L order and stop when the
sought library is found?
As far as testing, this patch has been applied to the pkgsrc clang 3.1
package. I know it works for the current release featuring gcc 4.7, and
verifying gcc 4.4 should be a simple matter of checking an earlier
DragonFly release that doesn't have gcc 4.7 available, so I can do that.
I was just trying to keep the patch simple.
John
More information about the cfe-commits
mailing list