[cfe-commits] [PATCH] Set some OpenCl specification mandated types/alignments/etc

[Eli Friedman]

On Wed, Nov 21, 2012 at 3:52 AM, David Tweed <David.Tweed at arm.com> wrote:
> Hi,
>
> the attached patch sets uses setForcedLangOptions to set certain types/alignments/etc which are completely specified by the OpenCL or SPIR specs. There's also a test for those things directly exposed at the user level. (The test is in Misc because the only specific OpenCL directory is for code-gen, which this isn't really... but I can move it somewhere else if desired.) Please review and if ok I'll commit.

Here's a potential counter-proposal: add new targets for OpenCL,
because there could potentially be other things an OpenCL
implementation needs to tweak on a per-target basis (e.g. #defines).
I would like to see a comment from someone else with a different
OpenCL implementation to check what vendors are currently doing.


If you think this really is the best approach, please change the test
to specifically test triples you consider important.

-Eli