[cfe-commits] [PATCH] First OpenMP patch

[Mahesha HS]

Hi Joey,

I will change test case by adding FileCheck and remove grep.

Comments seem to be confusing. Will change it.

This code will make sure that either OpenMP or NoOpenMP is on, or both
off. The next patch will check these flags, and contains necessary
test cases.

--
mahesha

On Wed, Nov 21, 2012 at 8:25 PM, Joey Gouly <joey.gouly at arm.com> wrote:
> Hi,
>
> You should make test/Driver/openmp-options.c use FileCheck, rather than
> grep.
>
> +  // If -fopenmp enablement fails, then check, if -fno-openmp is need to be
>
> +  // enabled.
>
> This comment confuses me, when does this happen? Also, there doesn't seem to
> be a test for this case.
>
> Otherwise, looks good.
>
> Thanks,
> Joey
>
> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu
> [mailto:cfe-commits-bounces at cs.uiuc.edu] On Behalf Of Mahesha HS
> Sent: 21 November 2012 14:36
> To: llvm cfe
> Subject: [cfe-commits] [PATCH] First OpenMP patch
>
> Hi all,
>
> Here is the first OpenMP patch.
>
> It supports options -fopenmp and -fno-openmp. When only -fopenmp is
> passed, OpenMP is enabled. When only -fno-openmp is passed, OpenMP is
> disabled. When both the options are passed, the one which appear later
> in the command line wins.
>
> I am re-sending this patch third time. I am positively hoping that -
> this time - this patch will get checked-in into trunk :)
>
> --
> mahesha
>
>
>



-- 
mahesha