Then I don't see how the flag is handled in this patch. And still, can we hide the has_color check inside changeColor/resetColor, so that clients only have to check additional conditions like -f[no-]color-diagnostics flag? http://llvm-reviews.chandlerc.com/D127