[cfe-commits] [PATCH] Use color for -ast-dump-filter only when it is supported

Dmitri Gribenko gribozavr at gmail.com
Mon Nov 19 11:49:45 PST 2012

Previous message: [cfe-commits] [PATCH] Use color for -ast-dump-filter only when it is supported
Next message: [cfe-commits] [PATCH] Use color for -ast-dump-filter only when it is supported
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

  LGTM.

  About the tests, I can not think of a good way to test this, since has_colors() boils down to isatty(fd).

http://llvm-reviews.chandlerc.com/D127

Previous message: [cfe-commits] [PATCH] Use color for -ast-dump-filter only when it is supported
Next message: [cfe-commits] [PATCH] Use color for -ast-dump-filter only when it is supported
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the cfe-commits mailing list