[cfe-commits] r168137 - in /cfe/trunk/unittests: Basic/SourceManagerTest.cpp Lex/LexerTest.cpp Lex/PPCallbacksTest.cpp Lex/PreprocessingRecordTest.cpp

[NAKAMURA Takumi]

2012/11/17 Matthieu Monrocq <matthieu.monrocq at gmail.com>:
>
>
> On Fri, Nov 16, 2012 at 5:40 AM, NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
>>
>> Author: chapuni
>> Date: Thu Nov 15 22:40:11 2012
>> New Revision: 168137
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=168137&view=rev
>> Log:
>> clang/unittests: Fixup corresponding to Doug's r168136.
>>
>> Modified:
>>     cfe/trunk/unittests/Basic/SourceManagerTest.cpp
>>     cfe/trunk/unittests/Lex/LexerTest.cpp
>>     cfe/trunk/unittests/Lex/PPCallbacksTest.cpp
>>     cfe/trunk/unittests/Lex/PreprocessingRecordTest.cpp
>>
>> Modified: cfe/trunk/unittests/Basic/SourceManagerTest.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Basic/SourceManagerTest.cpp?rev=168137&r1=168136&r2=168137&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/unittests/Basic/SourceManagerTest.cpp (original)
>> +++ cfe/trunk/unittests/Basic/SourceManagerTest.cpp Thu Nov 15 22:40:11
>> 2012
>> @@ -39,7 +39,7 @@
>>        SourceMgr(Diags, FileMgr),
>>        TargetOpts(new TargetOptions) {
>>      TargetOpts->Triple = "x86_64-apple-darwin11.1.0";
>> -    Target = TargetInfo::CreateTargetInfo(Diags, *TargetOpts);
>> +    Target = TargetInfo::CreateTargetInfo(Diags, &*TargetOpts);
>>    }
>>
>>    FileSystemOptions FileMgrOpts;
>>
>> Modified: cfe/trunk/unittests/Lex/LexerTest.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Lex/LexerTest.cpp?rev=168137&r1=168136&r2=168137&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/unittests/Lex/LexerTest.cpp (original)
>> +++ cfe/trunk/unittests/Lex/LexerTest.cpp Thu Nov 15 22:40:11 2012
>> @@ -39,7 +39,7 @@
>>        TargetOpts(new TargetOptions)
>>    {
>>      TargetOpts->Triple = "x86_64-apple-darwin11.1.0";
>> -    Target = TargetInfo::CreateTargetInfo(Diags, *TargetOpts);
>> +    Target = TargetInfo::CreateTargetInfo(Diags, &*TargetOpts);
>>    }
>>
>>    FileSystemOptions FileMgrOpts;
>>
>> Modified: cfe/trunk/unittests/Lex/PPCallbacksTest.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Lex/PPCallbacksTest.cpp?rev=168137&r1=168136&r2=168137&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/unittests/Lex/PPCallbacksTest.cpp (original)
>> +++ cfe/trunk/unittests/Lex/PPCallbacksTest.cpp Thu Nov 15 22:40:11 2012
>> @@ -84,7 +84,7 @@
>>        SourceMgr(Diags, FileMgr) {
>>      TargetOpts = new TargetOptions();
>>      TargetOpts->Triple = "x86_64-apple-darwin11.1.0";
>> -    Target = TargetInfo::CreateTargetInfo(Diags, *TargetOpts);
>> +    Target = TargetInfo::CreateTargetInfo(Diags, &*TargetOpts);
>>    }
>>
>>    FileSystemOptions FileMgrOpts;
>>
>> Modified: cfe/trunk/unittests/Lex/PreprocessingRecordTest.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/unittests/Lex/PreprocessingRecordTest.cpp?rev=168137&r1=168136&r2=168137&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/unittests/Lex/PreprocessingRecordTest.cpp (original)
>> +++ cfe/trunk/unittests/Lex/PreprocessingRecordTest.cpp Thu Nov 15
>> 22:40:11 2012
>> @@ -40,7 +40,7 @@
>>        TargetOpts(new TargetOptions)
>>    {
>>      TargetOpts->Triple = "x86_64-apple-darwin11.1.0";
>> -    Target = TargetInfo::CreateTargetInfo(Diags, *TargetOpts);
>> +    Target = TargetInfo::CreateTargetInfo(Diags, &*TargetOpts);
>>    }
>>
>
> Why &*TargetOps instead of just TargetOps ?

I followed what Doug did then, to fix trunk.
I'd re-edit them if they were safe w/o modifiers, or feel free to update them.

...Takumi