[cfe-commits] [Patch] Refactor duplicate string literal lexing code in Preprocessor

Andy Gibbs andyg1001 at hotmail.co.uk
Thu Nov 15 09:54:27 PST 2012


Hi,

Attached is a patch that refactors duplicate string literal lexing code 
within Preprocessor, into a common LexStringLiteral function.  In doing so, 
some consistency problems have been ironed out (e.g. where the first token 
in the string literal was lexed with macro expansion, but subsequent ones 
were not) and also an erroneous diagnostic has been corrected (I assume this 
one was caused by some copy-and-paste in the past!).

I have implemented LexStringLiteral with a complementary 
FinishLexStringLiteral function which can be used in the situation where the 
first token of the string literal has already been lexed.

Am I ok to commit this?

Thanks
Andy

-------------- next part --------------
A non-text attachment was scrubbed...
Name: refactor.diff
Type: application/octet-stream
Size: 17497 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121115/05aeefa0/attachment.obj>


More information about the cfe-commits mailing list