[cfe-commits] [Review] First step towards PR13231 - vftable generation with -cxx-abi microsoft

[Timur Iskhodzhanov]

Hi John, Peter,

Can you please review the attached patch?

With this patch, I can compile and run simple single-inheritance tests;
even method calls from Clang-generated obj files to CL-generated
methods work (and vice versa).

Some notes:
a) It only works with -fno-rtti since we can't mangle RTTI yet,

b) I had to remove "AddressPoint != 0" assertion since AddressPoint
should be 0 for some classes in -cxx-abi microsoft,

c) I've added conditionals rather than a layer of abstraction per
http://llvm.org/bugs/show_bug.cgi?id=13231#c5,

d) The complete/deleting dtor logic will change when we support MSVC
dtor types, but not now
    [shouldn't matter now that we still don't support virtual inheritance]

Thanks!
Timur Iskhodzhanov,
Google Russia
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bug_13231.patch
Type: application/octet-stream
Size: 10939 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121115/d1b0a4bb/attachment.obj>