[cfe-commits] [OpenCL patch] vec_type_hint

[Joey Gouly]

Hi Murat,

LGTM.

One minor thing:

+       llvm::APInt(32, (uint64_t) (isSignedInteger?1:0))));

You don't need the '?1:0' part, a bool will always be promoted with a value
of 0 or 1.

Thanks,
Joey

________________________________________
From: cfe-commits-bounces at cs.uiuc.edu [cfe-commits-bounces at cs.uiuc.edu] On
Behalf Of Murat Bolat [murat.bolat at arm.com]
Sent: 14 November 2012 13:18
To: cfe-commits at cs.uiuc.edu
Subject: [cfe-commits] [OpenCL patch] vec_type_hint

Hi,

Here is the updated patch for vec_type_hint attribute in OpenCL.
The previous discussion about it:
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120813/062502.h
tml

Thanks a lot!
Murat Bolat