[cfe-commits] r168007 - in /cfe/trunk: include/clang/Basic/LangOptions.def test/CodeGenObjC/extended-block-signature-encode.m

[Richard Smith]

On Wed, Nov 14, 2012 at 4:01 PM, Fariborz Jahanian <fjahanian at apple.com> wrote:
> Author: fjahanian
> Date: Wed Nov 14 18:01:28 2012
> New Revision: 168007
>
> URL: http://llvm.org/viewvc/llvm-project?rev=168007&view=rev
> Log:
> objective-C blocks: make cc1 flag -encode-extended-block-signature
> the default. // rdar://12109031

It looks like there's now no way to turn this off. Do we still need
the LangOption and -cc1 flag?

> Modified:
>     cfe/trunk/include/clang/Basic/LangOptions.def
>     cfe/trunk/test/CodeGenObjC/extended-block-signature-encode.m
>
> Modified: cfe/trunk/include/clang/Basic/LangOptions.def
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/LangOptions.def?rev=168007&r1=168006&r2=168007&view=diff
> ==============================================================================
> --- cfe/trunk/include/clang/Basic/LangOptions.def (original)
> +++ cfe/trunk/include/clang/Basic/LangOptions.def Wed Nov 14 18:01:28 2012
> @@ -104,7 +104,7 @@
>  LANGOPT(FiniteMathOnly    , 1, 0, "__FINITE_MATH_ONLY__ predefined macro")
>
>  BENIGN_LANGOPT(ObjCGCBitmapPrint , 1, 0, "printing of GC's bitmap layout for __weak/__strong ivars")
> -BENIGN_LANGOPT(ObjCExtendedBlockEncode , 1, 0, "Do extended encoding of block type signature")
> +BENIGN_LANGOPT(ObjCExtendedBlockEncode , 1, 1, "Do extended encoding of block type signature")
>
>  BENIGN_LANGOPT(AccessControl     , 1, 1, "C++ access control")
>  LANGOPT(CharIsSigned      , 1, 1, "signed char")
>
> Modified: cfe/trunk/test/CodeGenObjC/extended-block-signature-encode.m
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenObjC/extended-block-signature-encode.m?rev=168007&r1=168006&r2=168007&view=diff
> ==============================================================================
> --- cfe/trunk/test/CodeGenObjC/extended-block-signature-encode.m (original)
> +++ cfe/trunk/test/CodeGenObjC/extended-block-signature-encode.m Wed Nov 14 18:01:28 2012
> @@ -1,5 +1,5 @@
>  // RUN: %clang_cc1 -fblocks -triple x86_64-apple-darwin -encode-extended-block-signature -emit-llvm %s -o - | FileCheck %s
> -// RUN: %clang_cc1 -fblocks -triple x86_64-apple-darwin -emit-llvm %s -o - | FileCheck %s -check-prefix=BRIEF
> +// RUN: %clang_cc1 -fblocks -triple x86_64-apple-darwin -emit-llvm %s -o - | FileCheck %s -check-prefix=EXPANDED
>  // rdar://12109031
>
>  @class NSString, NSArray;
> @@ -12,4 +12,4 @@
>    ^(BBB arg1, double arg2){ return b1; }(0, 3.14);
>  }
>  // CHECK: @{{.*}} = private unnamed_addr constant [64 x i8] c"@?<@\22NSString\22@?@\22NSArray\22>24@?0@?<@\22NSString\22@?@\22NSArray\22>8d16\00"
> -// CHECK-BRIEF: @{{.*}} = private unnamed_addr constant [14 x i8] c"@?24@?0@?8d16\00"
> +// CHECK-EXPANDED: @{{.*}} = private unnamed_addr constant [64 x i8] c"@?<@\22NSString\22@?@\22NSArray\22>24@?0@?<@\22NSString\22@?@\22NSArray\22>8d16\00"
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits