[cfe-commits] [PATCH] Add #pragma region for MSVC mode

[Aaron Ballman]

On Tue, Nov 13, 2012 at 3:40 AM, pravic <ehysta at gmail.com> wrote:
>   update according to latest notes.
>
> Hi triton, chapuni, rsmith,
>
> http://llvm-reviews.chandlerc.com/D65
>
> CHANGE SINCE LAST DIFF
>   http://llvm-reviews.chandlerc.com/D65?vs=300&id=305#toc
>
> Files:
>   lib/Lex/Pragma.cpp
>   test/Lexer/pragma-region.c
>
> Index: lib/Lex/Pragma.cpp
> ===================================================================
> --- lib/Lex/Pragma.cpp
> +++ lib/Lex/Pragma.cpp
> @@ -1277,6 +1277,29 @@
>    }
>  };
>
> +  /// \brief Handle "\#pragma region [...]"
> +  ///
> +  /// The syntax is
> +  /// \code
> +  ///   \#pragma region [optional name]
> +  ///   \#pragma endregion [optional comment]
> +  /// \endcode
> +  ///
> +  /// \note This is
> +  /// <a href="http://msdn.microsoft.com/en-us/library/b6xkz944(v=vs.80).aspx">editor-only</a>

This is over the 80 column limit, but I'm not certain what the correct
behavior is here.  If we split it at 80, it makes the link harder to
follow (for instance, Visual Studio won't treat it as a link so you
can no longer simply click on it).  Opinions (or precedence in the
code base) welcome.

Everything else LGTM.

~Aaron