[cfe-commits] r167786 - in /cfe/trunk: lib/Sema/SemaOverload.cpp test/SemaTemplate/dependent-names.cpp

[Eli Friedman]

On Wed, Nov 14, 2012 at 12:21 PM, Dmitri Gribenko <gribozavr at gmail.com> wrote:
> On Tue, Nov 13, 2012 at 2:08 AM, Nick Lewycky <nicholas at mxc.ca> wrote:
>> Author: nicholas
>> Date: Mon Nov 12 18:08:34 2012
>> New Revision: 167786
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=167786&view=rev
>> Log:
>> When filtering the list of associated namespaces so that we don't suggest people
>> add functions to namespace 'std', also filter out namespaces with '__' anywhere
>> in the name.
>
> Isn't it a bit too broad to exclude namespaces containing "__"
> anywhere, rather than only at the beginning?

"Each name that contains a double underscore [...] is reserved to the
implementation for any use."  Granted, it still might be overbroad in
practice.

-Eli