[cfe-commits] r167783 - in /cfe/trunk: include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp lib/Sema/SemaDeclAttr.cpp test/SemaCXX/warn-unused-result.cpp

[Richard Smith]

Hi,

On Mon, Nov 12, 2012 at 4:23 PM, Michael Han <Michael.Han at autodesk.com> wrote:
> Hi Richard,
>
> Shall we use CXX11<"gnu", "warn_unused_result"> instead? It seems to me that this attribute is not a clang only language extension (e.g. [[clang::fallthrough]]), but a GNU function attribute, and I believe what we plan to do in terms of migrating existing GNU attributes to C++11 syntax is to put them under "gnu" namespace..

I would expect this to happen as a natural consequence of our starting
to accept the [[gnu::*]] attributes everywhere, rather than due to a
specific change here. I'm also wondering whether we should reject
[[gnu::warn_unused_result]] on class types, to match the g++
implementation.