[cfe-commits] r167761 - in /cfe/trunk: lib/Sema/SemaStmtAsm.cpp test/CodeGen/x86_32-inline-asm.c

[Eric Christopher]

Hi Bill,

On Mon, Nov 12, 2012 at 2:01 PM, Bill Wendling <isanbard at gmail.com> wrote:

> Author: void
> Date: Mon Nov 12 16:01:56 2012
> New Revision: 167761
>
> URL: http://llvm.org/viewvc/llvm-project?rev=167761&view=rev
> Log:
> Don't test for incomplete types.
>
> Modified:
>     cfe/trunk/lib/Sema/SemaStmtAsm.cpp
>     cfe/trunk/test/CodeGen/x86_32-inline-asm.c
>

 I've temporarily reverted this for you since it seems like it was causing
test failures in ToT (SemaTemplate/instantiate-expr-1.cpp). Also, not quite
sure what you're trying to do with the fix? If you'd like people to be able
to load from incomplete types (likely use case) you'll need to avoid the
validation code. Is it erroring out here? Also, that testcase looks kinda
funky, it'd be nice to get a different testcase when you reapply than the
first one.

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121112/aef7d18a/attachment.html>