[cfe-commits] [PATCH] [VCPP] Add __ptr64 qualifier

[Charles Davis]

  Files still have wrong line endings (should be LF, not CR-LF). That's kinda annoying, because when the commit goes through, we'll see basically the whole file diff'd and we can't see where the actual, substantial changes took place.


================
Comment at: test/CodeGenCXX/mangle-ms-ptr64.cpp:7-9
@@ +6,5 @@
+
+// CHECK: @"\01?VS_p32@@3PAHA" = global i32* null
+// CHK64: @"\01?VS_p32@@3PAHA" = global i32* null
+int * __ptr32 VS_p32;
+
----------------
Clang currently recognizes the `__ptr32` and `__ptr64` keywords, but doesn't yet attach them to the declaration. We haven't yet worked out exactly how to do that. One way might be to assign the non-native pointer size (i.e. `__ptr32` in 64-bit mode and `__ptr64` in 32-bit mode) to a different address space. But that requires Micah's pointer-sizes-in-address-spaces work, which was just recently reverted.

I'm open to suggestions.


http://llvm-reviews.chandlerc.com/D101