[cfe-commits] [PATCH] Support -fsanitize= option on Darwin toolchain

[Alexander Potapenko]

  LGTM


================
Comment at: lib/Driver/SanitizerArgs.h:86
@@ +85,3 @@
+
+  /// Produce an argument string from argument \p A, which shows how it provides a
+  /// value in \p Mask. For instance, the argument "-fsanitize=address,alignment"
----------------
Line > 80 chars (hint: search for "⬅")

================
Comment at: lib/Driver/SanitizerArgs.h:80
@@ +79,3 @@
+      else
+        D.Diag(diag::err_drv_unsupported_option_argument)
+          << A->getOption().getName() << A->getValue(I);
----------------
I'd avoid omitting the curly braces for multiline else-clause, but YMMV.


http://llvm-reviews.chandlerc.com/D103