[cfe-commits] [PATCH] [VCPP] Mangle template parameters pack

[Charles Davis]

  Perhaps you should move the 64-bit tests into {D101}? (I've highlighted a few below.) Also, I would very much suggest that you please run the tests before submitting again. We have them for a reason, you know :).


================
Comment at: test/CodeGenCXX/mangle-ms-variadic-templates.cpp:10
@@ +9,3 @@
+	// CHECK: call void @"\01??$va@$$$V@@YAXXZ"()
+	// CHK64: call void @"\01??$va@$$$V@@YAXXZ"()
+	va();
----------------
This one won't pass unless {D101} is committed, too. In general, patches should be largely self-contained.

================
Comment at: test/CodeGenCXX/mangle-ms-variadic-templates.cpp:13
@@ +12,3 @@
+	// CHECK: call void @"\01??$va at H@@YAXH at Z"(i32 1)
+	// CHK64: call void @"\01??$va at H@@YAXH at Z"(i32 1)
+	va(1);
----------------
Ditto.

================
Comment at: test/CodeGenCXX/mangle-ms-variadic-templates.cpp:16
@@ +15,3 @@
+	// CHECK: call void @"\01??$va at HN@@YAXHN at Z"(i32 1, double 2.300000e+00)
+	// CHK64: call void @"\01??$va at HN@@YAXHN at Z"(i32 1, double 2.300000e+00)
+	va(1,2.3);
----------------
Idem.

================
Comment at: test/CodeGenCXX/mangle-ms-variadic-templates.cpp:19
@@ +18,3 @@
+	// CHECK: call void @"\01??$va at M@@YAXM at Z"(float 2.500000e+00)
+	// CHK64: call void @"\01??$va at M@@YAXM at Z"(float 2.500000e+00)
+	va(2.5f);
----------------
Same here.

================
Comment at: test/CodeGenCXX/mangle-ms-variadic-templates.cpp:34
@@ +33,3 @@
+	// CHECK: %struct.VS* @"\01??0?$VS@$$$V@@QAE at XZ"(%struct.VS* %vs0)
+	// CHK64: %struct.VS* @"\01??0?$VS@$$$V@@QEAA at XZ"(%struct.VS* %vs0)
+	VS<> vs0;
----------------
And so on for basically any `CHK64` line.


http://llvm-reviews.chandlerc.com/D99