[cfe-commits] [PATCH] Add #pragma region for MSVC mode

[Dmitri Gribenko]

================
Comment at: lib/Lex/Pragma.cpp:1280
@@ -1279,1 +1279,3 @@
 
+/// \bried PragmaRegionHandler - "\#pragma region [...]"
+///
----------------
Typo: bried.

Please don't duplicate struct name in the comment.

================
Comment at: lib/Lex/Pragma.cpp:1301
@@ +1300,3 @@
+  }
+
+
----------------
Please remove this unneeded whitespace.


================
Comment at: lib/Lex/Pragma.cpp:1288
@@ +1287,3 @@
+struct PragmaRegionHandler : public PragmaHandler {
+  PragmaRegionHandler(const char* pragma)
+    :PragmaHandler(pragma)
----------------
Star should be next to the identifier.

================
Comment at: test/Lexer/pragma-region.c:13
@@ +12,3 @@
+/* inner space */
+#pragma endregion
+
----------------
What about an 'endregion' without a matching 'region'?  Does MSVC ignore it silently?


http://llvm-reviews.chandlerc.com/D65