[cfe-commits] Micro-patch: Unify VoidModuleLoaders

[Kim Gräsman]

Hi Argyrios, Doug,

On Mon, Nov 5, 2012 at 8:50 PM, Douglas Gregor <dgregor at apple.com> wrote:

>
> On Nov 5, 2012, at 11:44 AM, Argyrios Kyrtzidis <kyrtzidis at apple.com>
> wrote:
>
> > Could we change the Preprocessor to accept an optional pointer to a
> ModuleLoader ?
>

Since Preprocessor has a getModuleLoader() method, that would force
null-checks on all callers. Currently only 2 of them, so no big deal, but I
tend to shy away from exposing NULLs.


> > This will eliminate the whole "VoidModuleLoader" business and the hack
> of having the ASTUnit "implement" a ModuleLoader just so we have something
> to pass to the Preprocessor when loading an AST file.
>

I didn't know about that hack. If there was a VoidModuleLoader next to
ModuleLoader, you could use that ;-)

- Kim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121105/bfee0e81/attachment.html>