[cfe-commits] Cilk Plus Extension for Clang

[Pan, Wei]

Hi Richard and Eli,

Thanks for the comments!  I just created a new patch with "git format-patch master..mybranch" and it should work now. A svn version is also attached.

Thanks again!

Wei    

-----Original Message-----
From: metafoo at gmail.com [mailto:metafoo at gmail.com] On Behalf Of Richard Smith
Sent: Thursday, November 01, 2012 6:27 PM
To: Pan, Wei
Cc: Eli Friedman; llvm cfe
Subject: Re: [cfe-commits] Cilk Plus Extension for Clang

--- include/clang/Driver/Options.td
+++ include/clang/Driver/Options.td
@@ -587,6 +587,9 @@ def fobjc_sender_dependent_dispatch : Flag<["-"], "fobjc-sender-dependent-dispat  def fobjc : Flag<["-"], "fobjc">, Group<f_Group>;  def fomit_frame_pointer : Flag<["-"], "fomit-frame-pointer">, Group<f_Group>;  def fopenmp : Flag<["-"], "fopenmp">, Group<f_Group>;
+def fcilkplus : Flag<["-"], "fcilkplus">, Group<f_Group>, 
+Flags<[CC1Option]>,
+  HelpText<"Enable Cilk Plus extensions">; def fno_cilkplus : 
+Flag<["-"], "fno-cilkplus">, Group<f_Group>,
Flags<[CC1Option]>;

Your -cc1 changes only accept -fcilkplus, not -fno-cilkplus, so -fno-cilkplus shouldn't have Flags<[CC1Option]>.

On Thu, Nov 1, 2012 at 2:59 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
> On Thu, Nov 1, 2012 at 10:09 AM, Pan, Wei <wei.pan at intel.com> wrote:
>> Hello All,
>>
>> Our team would like to add the Cilk Plus extension to Clang for C/C++ (http://software.intel.com/file/40297). To meet the requirements that Clang sets, we would like to keep our patches small and upstream our patches as early as possible. We would appreciate any guidance that the community could provide during the course of the implementation. Attached is our first patch that enables the Cilk Plus extension option. Looking forward to your review and comments!
>
> This patch doesn't apply against trunk.
>
> -Eli
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fcilkplus.patch
Type: application/octet-stream
Size: 4273 bytes
Desc: fcilkplus.patch
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121102/d5b5f36b/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fcilkplus_svn.diff
Type: application/octet-stream
Size: 3530 bytes
Desc: fcilkplus_svn.diff
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121102/d5b5f36b/attachment-0001.obj>