[cfe-commits] [PATCH] Clean up StmtDumper indentation

Manuel Klimek klimek at google.com
Thu Nov 1 06:40:44 PDT 2012

Comment at: lib/AST/StmtDumper.cpp:33
@@ -32,2 +32,3 @@
     unsigned IndentLevel;
+    bool NeedNewLine;
I think it's not immediately clear what cases are handled by this bool - a comment would help me here...

After reading the whole patch, it looks like this is mainly there for the first newline... If that's true, I'd probably call it IsFirstLine or something.

Comment at: lib/AST/StmtDumper.cpp:92
@@ +91,3 @@
+    void flush() {
+      if (NeedNewLine)
+        OS << "\n";
Can that ever be false in flush()


More information about the cfe-commits mailing list