[cfe-commits] [PATCH] Fix x86 android support in clang

[Vane, Edwin]

On 31 October 2012 15:12, Vane, Edwin <edwin.vane at intel.com> wrote:
>> -        CPUName = "pentium4";
>> +        CPUName = isAndroid ? "atom" : "pentium4";
>
> This matches gcc behavior? Can you add a test for this part?
>
> REV: Sure but what test case would I adjust? These options only seem to show up for compiling and I couldn't find a test suite for testing android compilation. I'll double-check with gcc.

You can test the -target-cpu that the driver is passing to "clang -cc1", no?

REV: I know *how* I'd write the test, I'm just not sure which actual test suite it belongs to. For example, test/Driver/linux-ld.c has linking tests for android but I couldn't find any existing tests for testing compilation. If you could point me at the right test suite I'll add tests there.

Cheers,
Rafael