[cfe-commits] [PATCH] Add missing "static" to altivec.h

[Hal Finkel]

----- Original Message -----
> From: "Ulrich Weigand" <Ulrich.Weigand at de.ibm.com>
> To: cfe-commits at cs.uiuc.edu
> Sent: Wednesday, October 31, 2012 11:26:29 AM
> Subject: [cfe-commits] [PATCH] Add missing "static" to altivec.h
> 
> 
> Hello,
> 
> a small number of the inline routines in altivec.h are missing the
> "static"
> specifier (most routines already have it).  This causes the compiler
> to
> emit an out-of-line copy of those routines into every file compiled
> with
> -maltivec; if multiple such files are linked together, this causes a
> linker
> error.  This happens e.g. when attempting to self-host clang on
> PowerPC at
> the moment ...
> 
> The attached patch adds those missing "static" specifiers.  With this
> patch, I'm able to use clang to build clang on PowerPC.
> 
> OK to commit?

The change looks good. Should we add a testcase?

 -Hal

> 
> Bye,
> Ulrich
> 
> (See attached file: diff-clang-altivec)
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> 

-- 
Hal Finkel
Postdoctoral Appointee
Leadership Computing Facility
Argonne National Laboratory