[cfe-commits] [PATCH] Remove -Wdisabled-macro-expansion

[Eli Friedman]

On Tue, Oct 30, 2012 at 12:00 PM, Ted Kremenek <kremenek at apple.com> wrote:
> On Oct 30, 2012, at 12:27 AM, Abramo Bagnara <abramo.bagnara at bugseng.com>
> wrote:
>
> If others agree with this argument, I can see a strong argument here to
> remove the warning entirely.
>
>
> This thread clarifies why the warning is very important for a class of
> users and why to reach the same aim has no pratical alternatives
>
> http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20111226/050687.html
>
>
> Thanks for the reference.
>
> Eli: is it acceptable to use the _Pragma solution to silence the warning for
> this one case?

I've thought about it a bit more, and it strikes me as too dangerous:
if we expand "true" to something which isn't "true", and someone tries
to paste it with another token, things explode.  If we're going to
mess with them at all, the least dangerous thing to do would be to
remove them.

-Eli