[cfe-commits] [PATCH] Remove -Wdisabled-macro-expansion

[Ted Kremenek]

On Oct 29, 2012, at 11:08 PM, Eli Friedman <eli.friedman at gmail.com> wrote:

> On Mon, Oct 29, 2012 at 9:04 PM, Ted Kremenek <kremenek at apple.com> wrote:
>> On Oct 29, 2012, at 5:53 PM, Eli Friedman <eli.friedman at gmail.com> wrote:
>> 
>> Per subject, remove -Wdisabled-macro-expansion.  It's triggering on
>> normal uses of stdbool.h in C++ (at least, however normal it is to use
>> stdbool.h in C++). Because we're trying to encourage people to use
>> -Weverything, it isn't acceptable for it to trigger warnings for usage
>> of headers included with the compiler, and as far as I can tell, there
>> isn't any way to fix the header.  (See patch for a testcase that
>> checks we don't trigger any warnings from stdbool.h.)
>> 
>> 
>> If the warning has general utility, wouldn't another reasonable fix be to
>> silence the warning where it is happening in stdbool.h?  We have pragmas for
>> doing just that.
> 
> Hmm, I hadn't thought of that: using _Pragma to suppress this warning
> would be extremely ugly,  but it'd work, I guess.

Indeed, but everyday users won't look at the header.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121030/0210d46e/attachment.html>