[cfe-commits] r167003 - /cfe/trunk/include/clang/Basic/DiagnosticGroups.td

[Ted Kremenek]

Sorry!  Looks like that wasn't included in my commit.

On Oct 29, 2012, at 10:22 PM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:

> Ted, should a test be updated?
> 
> 
> ******************** TEST 'Clang ::
> SemaCXX/no-warn-composite-pointer-type.cpp' FAILED
> ********************Script:
> --
> /home/bb/cmake-clang-x86_64-linux/build/bin/./clang -cc1
> -internal-isystem
> /home/bb/cmake-clang-x86_64-linux/build/bin/../lib/clang/3.2/include
> -fsyntax-only -Wno-compare-distinct-pointer-type -verify
> /home/bb/cmake-clang-x86_64-linux/llvm-project/clang/test/SemaCXX/no-warn-composite-pointer-type.cpp
> --
> Exit Code: 1
> Command Output (stderr):
> --
> error: 'warning' diagnostics seen but not expected:
>  (frontend): unknown warning option
> '-Wno-compare-distinct-pointer-type'; did you mean
> '-Wno-compare-distinct-pointer-types'?
>  Line 7: comparison of distinct pointer types ('int **' and 'const
> int **') uses non-standard composite pointer type 'const int *const *'
> 2 errors generated.
> --
> 
> ********************
> 
> 2012/10/30 Ted Kremenek <kremenek at apple.com>:
>> Author: kremenek
>> Date: Mon Oct 29 23:43:57 2012
>> New Revision: 167003
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=167003&view=rev
>> Log:
>> Change -Wcompare-distinct-pointer-type to -Wcompare-distinct-pointer-types, as
>> the warning is about comparing different types (plural).
>> 
>> Modified:
>>    cfe/trunk/include/clang/Basic/DiagnosticGroups.td
>> 
>> Modified: cfe/trunk/include/clang/Basic/DiagnosticGroups.td
>> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/DiagnosticGroups.td?rev=167003&r1=167002&r2=167003&view=diff
>> ==============================================================================
>> --- cfe/trunk/include/clang/Basic/DiagnosticGroups.td (original)
>> +++ cfe/trunk/include/clang/Basic/DiagnosticGroups.td Mon Oct 29 23:43:57 2012
>> @@ -209,7 +209,7 @@
>>                                     [TautologicalOutOfRangeCompare]>;
>> def HeaderHygiene : DiagGroup<"header-hygiene">;
>> def DuplicateDeclSpecifier : DiagGroup<"duplicate-decl-specifier">;
>> -def CompareDistinctPointerType : DiagGroup<"compare-distinct-pointer-type">;
>> +def CompareDistinctPointerType : DiagGroup<"compare-distinct-pointer-types">;
>> 
>> // Preprocessor warnings.
>> def : DiagGroup<"builtin-macro-redefined">;
>> 
>> 
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits