[cfe-commits] [PATCH] Change ForceSizeOpt attribute into MinSize attribute

[Chandler Carruth]

On Mon, Oct 29, 2012 at 6:58 PM, Quentin Colombet <qcolombet at apple.com> wrote:
> Chandler,
>
> Is this patch ok for you?
> (The cfe counter part of my proposed patch for llvm)

Ah, yes, LGTM.

>
> Thanks,
>
> Quentin
>
> On Oct 29, 2012, at 4:44 PM, Eric Christopher <echristo at gmail.com> wrote:
>
>> On Mon, Oct 29, 2012 at 4:43 PM, Quentin Colombet <qcolombet at apple.com> wrote:
>>>
>>> On Oct 29, 2012, at 4:23 PM, Eric Christopher <echristo at gmail.com> wrote:
>>>
>>>> On Mon, Oct 29, 2012 at 4:15 PM, Quentin Colombet <qcolombet at apple.com> wrote:
>>>>> Hi,
>>>>>
>>>>> Following a discussion on the "Oz optimization level sets ForceSizeOpt attribute for each function", I propose a patch to change the name of the ForceSizeOpt attribute into MinSize attribute.
>>>>>
>>>>> The purpose of this attribute is to inform the compiler that functions decorated with should be optimized to minimize for code size.
>>>>>
>>>>
>>>> Not quite sure why the one testcase was removed? Otherwise it looks
>>>> fine of course.
>>>
>>> The test case is still there, but I renamed the file from attr-forcesizeopt.c to attr-minsize.c. Interestingly, svn diff does not show the differences as a new file but use the previous file as a base (thus few modifications)
>>>
>>
>> Aha. Weird. OK then :)
>>
>> -eric
>