[cfe-commits] [PATCH] crash on invalid namespace-alias-definition syntax

[Brian Brooks]

Updated patch with test case added.  Thanks for catching that!


On Sat, Oct 27, 2012 at 1:16 AM, Nico Weber <thakis at chromium.org> wrote:

> Thanks for the patch!
>
> Instead of adding a bool, can you just check if Ident is not 0? Also,
> can you please add a test case? You can add the whole test suite with
> `make test` and an individual test e.g. like `../../utils/lit/lit.py
> -v test/Parser/cxx-member-crash.cpp`. Maybe you can just create
> test/Parser/cxx-crash.cpp which can become a collection of parser
> crash tests.
>
> Nico
>
> On Fri, Oct 26, 2012 at 10:07 PM, Brian Brooks <brooks.brian at gmail.com>
> wrote:
> > Attached is a patch for the following bug:
> >
> > http://llvm.org/bugs/show_bug.cgi?id=14085
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121027/9d6ee3f9/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: namespace-alias-definition2.patch
Type: application/octet-stream
Size: 961 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121027/9d6ee3f9/attachment.obj>