[cfe-commits] [llvm-commits] Reduce exception handling use in TableGen

Joerg Sonnenberger joerg at britannica.bec.de
Thu Oct 25 11:40:21 PDT 2012


Hi all,
this is the second version of the patch. A small part already went into
the tree (PrintFatalError and the clang changes, except
CMakeLists.txt/Makefile).

The one really nasty part of this change is CodeGenDAGPattern.cpp. I've
changed the TreePattern code to provide a sticky marker. The first error
hit during the resolution process is printed and it tries to bail out
from that. I am not completely sure if the current logic is aggressive
enough or whether hasError() checks are needed in a few more cases.
Since this only matters for at least somewhat broken specifications, it
shouldn't be a problem to add more checks as needed.

Joerg
-------------- next part --------------
A non-text attachment was scrubbed...
Name: no-exception.diff
Type: text/x-diff
Size: 114824 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121025/6c349250/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: no-exception-clang.diff
Type: text/x-diff
Size: 703 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121025/6c349250/attachment-0001.diff>


More information about the cfe-commits mailing list