[cfe-commits] [PATCH] PR14097, no debug info for artificial/'nodebug' methods

[Alexey Samsonov]

On Wed, Oct 24, 2012 at 10:46 PM, Eric Christopher <echristo at gmail.com>wrote:

> On Wed, Oct 24, 2012 at 4:15 AM, Alexey Samsonov <samsonov at google.com>
> wrote:
> > On Wed, Oct 17, 2012 at 9:48 PM, Eric Christopher <echristo at gmail.com>
> > wrote:
> >>
> >> I've gone ahead and reverted it here:
> >>
> >>         D       test/CodeGenCXX/debug-info-user-def.cpp
> >>         M       test/CodeGenCXX/debug-lambda-expressions.cpp
> >>         M       test/CodeGenCXX/debug-info-template-quals.cpp
> >>         M       test/CodeGenCXX/debug-info-template-member.cpp
> >>         M       lib/CodeGen/CGDebugInfo.cpp
> >> W: -empty_dir: test/CodeGenCXX/debug-info-user-def.cpp
> >> r166109 = 7c70a2300fbd713858c31cc9cbbe074bdc233412
> >> (refs/remotes/origin/master)
> >>
> >> Feel free to rebase some test suite changes on top of that.
> >>
> >>
> >> Alexey: If you need anything else let me know.
> >
> >
> > Yes, I think I still need a review for patch for PR13942.
> >
> > https://codereview.appspot.com/6720044/
> >
>
> LGTM. One possible cleanup for later: we have a lot of maybe... calls
> scattered all over the place. It'd be nice if we could get them
> consolidated somehow.
>
> r166676, thanks!

-- 
Alexey Samsonov, MSK
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20121025/0a7ea3a0/attachment.html>